[Webkit-unassigned] [Bug 135358] Create a more generic way for VMEntryScope to notify those interested that it will be destroyed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135358


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235635|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Geoffrey Garen <ggaren at apple.com>  2014-07-28 16:27:34 PST ---
(From update of attachment 235635)
View in context: https://bugs.webkit.org/attachment.cgi?id=235635&action=review

> Source/JavaScriptCore/debugger/Debugger.cpp:338
> +        VMEntryScope::EntryScopeDidPopListener callback = [this] (VM* vm, JSGlobalObject* globalObject) 

This is probably a good place to use "auto".

> Source/JavaScriptCore/debugger/Debugger.cpp:341
> +            if (globalObject->debugger() && globalObject->debugger() == this)
> +                this->recompileAllJSFunctions(vm);

It feels weird to use 'this' here, since we can't guarantee its lifetime. I think it would be better to use globalObject->debugger() instead of 'this'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.