[Webkit-unassigned] [Bug 135287] BuildFix: JavaScriptCore/bytecode/StructureSet.h:262:77: warning

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135287





--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2014-07-28 08:03:32 PST ---
(In reply to comment #2)
> (From update of attachment 235514 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235514&action=review
> 
> I think the new version of StructureSet was rolled out of the tree; this patch isn’t relevant until we bring it back in.

It's rolled back in. There are more changes now so this does need to be rebased. 

But r=me too. This change is fine. 

> 
> Best would be to make sure Filip fixes this before he re-lands the new code.
> 
> > Source/JavaScriptCore/bytecode/StructureSet.h:43
> > +        : m_pointer(0)
> 
> Please use nullptr.

It's a uintptr, so that would be weird. Would it even work?

I think it would be weird even if it did work since the point of explicitly setting it is to clear the low tag bits. 

> 
> > Source/JavaScriptCore/bytecode/StructureSet.h:49
> > +        : m_pointer(0)
> 
> Please use nullptr.

Ditto. 

> 
> > Source/JavaScriptCore/bytecode/StructureSet.h:55
> > +        : m_pointer(0)
> 
> Not sure it’s needed in this case. I didn’t carefully study copyFrom, but I don’t think it uses the old m_pointer value.

I think that copyFrom leaves the low bits alone, so we need this change here also.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.