[Webkit-unassigned] [Bug 135287] BuildFix: JavaScriptCore/bytecode/StructureSet.h:262:77: warning

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 27 23:33:54 PDT 2014


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #235514|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2014-07-27 23:34:07 PST ---
(From update of attachment 235514)
View in context: https://bugs.webkit.org/attachment.cgi?id=235514&action=review

I think the new version of StructureSet was rolled out of the tree; this patch isn’t relevant until we bring it back in.

Best would be to make sure Filip fixes this before he re-lands the new code.

> Source/JavaScriptCore/bytecode/StructureSet.h:43
> +        : m_pointer(0)

Please use nullptr.

> Source/JavaScriptCore/bytecode/StructureSet.h:49
> +        : m_pointer(0)

Please use nullptr.

> Source/JavaScriptCore/bytecode/StructureSet.h:55
> +        : m_pointer(0)

Not sure it’s needed in this case. I didn’t carefully study copyFrom, but I don’t think it uses the old m_pointer value.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list