[Webkit-unassigned] [Bug 129653] [soup] Propagate TLS error information for resource requests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 16 11:43:58 PDT 2014


--- Comment #9 from Ben Boeckel <mathstuf at gmail.com>  2014-07-16 11:44:12 PST ---
Thanks for the review.

(In reply to comment #8)
> What does this fix or how does this improve things? Are you fixing a specific bug?

That's filed in bugzilla? No. The problem is that when an SSL error occurs, there's no information available for a browser to say "here's the certificate that failed; do you want to ignore the error?". Currently, there's nothing there since the generic error doesn't contain such information.

Of course, things may have changed since I last checked; I'll see if I can get my WebKit repository up to speed tonight and double check the state of things (i.e., whether the patch is necessary and still provides the correct information).

> > Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp:57
> > +    if (message && SOUP_STATUS_IS_TRANSPORT_ERROR(message->status_code)) {
> This should be turned into an early return, so reverse the check and return generic error immediately.

Sounds good.

> > Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp:61
> > +        ResourceError error = transportError(request, message->status_code,
> >              String::fromUTF8(message->reason_phrase));
> > -    else
> > -        return genericGError(error, request);
> > +        if (message->status_code == SOUP_STATUS_SSL_FAILED) {
> > +            GTlsCertificate* certificate;
> Nit: an empty line before the if will make this more readable I think.

Will change.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list