[Webkit-unassigned] [Bug 129653] [soup] Propagate TLS error information for resource requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129653


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225865|review?                     |review-
               Flag|                            |




--- Comment #8 from Gustavo Noronha (kov) <gns at gnome.org>  2014-07-16 11:14:31 PST ---
(From update of attachment 225865)
View in context: https://bugs.webkit.org/attachment.cgi?id=225865&action=review

What does this fix or how does this improve things? Are you fixing a specific bug?

> Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp:57
> +    if (message && SOUP_STATUS_IS_TRANSPORT_ERROR(message->status_code)) {

This should be turned into an early return, so reverse the check and return generic error immediately.

> Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp:61
> +        ResourceError error = transportError(request, message->status_code,
>              String::fromUTF8(message->reason_phrase));
> -    else
> -        return genericGError(error, request);
> +        if (message->status_code == SOUP_STATUS_SSL_FAILED) {
> +            GTlsCertificate* certificate;

Nit: an empty line before the if will make this more readable I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.