[Webkit-unassigned] [Bug 134804] [GTK] Do not include files that are not in git in the tarball

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134804





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-07-10 23:13:30 PST ---
(In reply to comment #2)
> (From update of attachment 234708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234708&action=review
> 
> > Tools/gtk/make-dist.py:94
> > +        self.files_in_cms = self.list_cms_files()
> 
> I'd prefer files_ins_vcs or files_in_version_control

I actually meant scm :-P which is what webkitpy uses, but I don't really mind either vcs or version_control

> > Tools/gtk/make-dist.py:104
> > +        cmd = ['git', 'ls-tree', '-r', '--name-only', 'HEAD', self.source_root]
> > +        p = subprocess.Popen(cmd, stdout=subprocess.PIPE)
> 
> This could be one line. This doesn't really support SVN. Is there a script in the WebKit scripts that can do this for us?

No, there isn't. It's very unlikely that someone will make a release without a git mirror, so I don't think it's worth it. I can leave a FIXME just in case someone want to add support for it (I won't)

> > Tools/gtk/make-dist.py:129
> > -                if not passes_all_rules(file):
> > +                if not passes_all_rules(file) or self.should_skip_file(file):
> 
> Is this going to do the right thing for files from the build directory?

Yes, it actually allows individual files when the source root is not in git (this is the case of files in buildir), assuming that in those cases they have been explicitly added by the manifest. We can try to be more restrictive here, and allow only files that are not in git when they are in the build dir.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.