[Webkit-unassigned] [Bug 134804] [GTK] Do not include files that are not in git in the tarball

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134804





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2014-07-10 10:30:44 PST ---
(From update of attachment 234708)
View in context: https://bugs.webkit.org/attachment.cgi?id=234708&action=review

> Tools/gtk/make-dist.py:94
> +        self.files_in_cms = self.list_cms_files()

I'd prefer files_ins_vcs or files_in_version_control

> Tools/gtk/make-dist.py:104
> +        cmd = ['git', 'ls-tree', '-r', '--name-only', 'HEAD', self.source_root]
> +        p = subprocess.Popen(cmd, stdout=subprocess.PIPE)

This could be one line. This doesn't really support SVN. Is there a script in the WebKit scripts that can do this for us?

> Tools/gtk/make-dist.py:129
> -                if not passes_all_rules(file):
> +                if not passes_all_rules(file) or self.should_skip_file(file):

Is this going to do the right thing for files from the build directory?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.