[Webkit-unassigned] [Bug 134589] [GTK] Use the same default options for production builds that previous stable releases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134589





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-07-10 03:09:04 PST ---
(In reply to comment #3)
> (From update of attachment 234339 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234339&action=review
> 
> Looks good, but we need to make accelerated canvas support conditional on CairoGL.

You are right.

> > Source/cmake/OptionsGTK.cmake:68
> > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS ON)
> 
> This should be determined by whether or not you have CairoGL support. The default should probably be off.

In stable it's on by default when cairo-gl is found in production. We should make sure that options enabled in production are also enabled in developer builds. We can change the default value if it was a mistake in stable, though.

> > Tools/Scripts/webkitperl/FeatureList.pm:158
> > -      define => "ENABLE_ACCELERATED_2D_CANVAS", default => 0, value => \$accelerated2DCanvasSupport },
> > +      define => "ENABLE_ACCELERATED_2D_CANVAS", default => isGtk(), value => \$accelerated2DCanvasSupport },
> 
> I think this is going to fail unless Cairo with GL support is installed. This isn't the typical installation on most systems.

Even if this is on by default here, it will be disabled later by cmake if the requirements are not found (once I add the checks for cairo-gl, I mean)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.