[Webkit-unassigned] [Bug 134589] [GTK] Use the same default options for production builds that previous stable releases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134589


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #234339|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2014-07-03 10:57:48 PST ---
(From update of attachment 234339)
View in context: https://bugs.webkit.org/attachment.cgi?id=234339&action=review

Looks good, but we need to make accelerated canvas support conditional on CairoGL.

> Source/cmake/OptionsGTK.cmake:68
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS ON)

This should be determined by whether or not you have CairoGL support. The default should probably be off.

> Tools/Scripts/webkitperl/FeatureList.pm:158
> -      define => "ENABLE_ACCELERATED_2D_CANVAS", default => 0, value => \$accelerated2DCanvasSupport },
> +      define => "ENABLE_ACCELERATED_2D_CANVAS", default => isGtk(), value => \$accelerated2DCanvasSupport },

I think this is going to fail unless Cairo with GL support is installed. This isn't the typical installation on most systems.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.