[Webkit-unassigned] [Bug 134724] fast/css/vertical-text-overflow-ellipsis* provide the wrong expectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134724





--- Comment #4 from Mario Sanchez Prada <mario at webkit.org>  2014-07-08 10:00:32 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > What if we remove those wrong expectations and convert the original tests to reftests (so the -expected.html file expects the right thing, hardcoding the ellipsis character) and then add the [ Failure ] expectation?
> > 
> > That way, when the problem is fixed the output of the .html and the -expected.html should match and that should be noticed while running the layout tests.
> 
> We still wouldn't catch new regressions that way.  In general, having any failing line in the test expectations is not great.

I see. But then the problem is that I would need to rebaseline the expectations for at least vertical-text-overflow-ellipsis-text-align-center.html and vertical-text-overflow-ellipsis-text-align-right.html when proposing the patch for 129313, since that will impact slightly how this vertical text is rendered, which (that rebaseline) is what I was trying to avoid with this bug report.

With that in my mind, and even if it's not perfect, I thought converting these vertical text tests to reftest now and marking the failure in TestExpectations would not be a so bad option, but I'm open to other suggestions if you have any.

Perhaps I should try to fix both the horizontal and vertical text at once as part of the patch for 129313, and then we could forget about this bug as all these vertical text tests would be converted along with that patch. What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.