[Webkit-unassigned] [Bug 134724] fast/css/vertical-text-overflow-ellipsis* provide the wrong expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 9 07:19:48 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=134724





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2014-07-09 07:20:04 PST ---
(In reply to comment #4)
> With that in my mind, and even if it's not perfect, I thought converting these vertical text tests to reftest now and marking the failure in TestExpectations would not be a so bad option, but I'm open to other suggestions if you have any.

We shouldn't do this.  It would mean that we're not testing anything since ref tests with ImageOnlyFailure expectation will NOT catch anything but crash.

> Perhaps I should try to fix both the horizontal and vertical text at once as part of the patch for 129313, and then we could forget about this bug as all these vertical text tests would be converted along with that patch. What do you think?

We can just rebaseline the test instead in your patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list