[Webkit-unassigned] [Bug 133818] Web Inspector: Selected DOM element highlights invisible near bottom of the viewport (topContentInset?)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133818





--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org>  2014-07-01 12:15:55 PST ---
(In reply to comment #9)
> (From update of attachment 234130 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234130&action=review
> 
> Hi Joe! Generally this concept behind this patch seems sound. But there are slightly better functions you can call to make it a little cleaner.
> 
> > Source/WebCore/inspector/InspectorOverlay.cpp:348
> > +    viewportSize.setHeight(viewportSize.height() + view->topContentInset());
> 
> Instead of fetching visibleContentRect and manually adding in the content inset, you can just call unobscuredContentRect()
> 
> > Source/WebCore/inspector/InspectorOverlay.cpp:349
> >      IntSize frameViewFullSize = view->visibleContentRectIncludingScrollbars().size();
> 
> And here instead of calling visibleContentRectIncludingScrollbars() and manually adding in the inset, you can call unobscuredContentRect(IncludeScrollbars)

Going with these versions I end up with slightly smaller rects, and the highlights do get clipped:

(lldb) p viewportSize // unobscuredContentRect
(WebCore::IntSize) $16 = (m_width = 1218, m_height = 669)
(lldb) p viewportSize1// visible + topContentInset
(WebCore::IntSize) $17 = (m_width = 1218, m_height = 707)

(lldb) p frameViewFullSize // unobscuredContentRect(ScrollableArea::IncludeScrollbars)
(WebCore::IntSize) $18 = (m_width = 1218, m_height = 669)
(lldb) p frameViewFullSize1 // visibleWithScrollbars + topContentInset
(WebCore::IntSize) $19 = (m_width = 1218, m_height = 707)

Is there something else that I may be missing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.