[Webkit-unassigned] [Bug 133818] Web Inspector: Selected DOM element highlights invisible near bottom of the viewport (topContentInset?)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133818





--- Comment #9 from Beth Dakin <bdakin at apple.com>  2014-07-01 11:31:41 PST ---
(From update of attachment 234130)
View in context: https://bugs.webkit.org/attachment.cgi?id=234130&action=review

Hi Joe! Generally this concept behind this patch seems sound. But there are slightly better functions you can call to make it a little cleaner.

> Source/WebCore/inspector/InspectorOverlay.cpp:348
> +    viewportSize.setHeight(viewportSize.height() + view->topContentInset());

Instead of fetching visibleContentRect and manually adding in the content inset, you can just call unobscuredContentRect()

> Source/WebCore/inspector/InspectorOverlay.cpp:349
>      IntSize frameViewFullSize = view->visibleContentRectIncludingScrollbars().size();

And here instead of calling visibleContentRectIncludingScrollbars() and manually adding in the inset, you can call unobscuredContentRect(IncludeScrollbars)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.