[Webkit-unassigned] [Bug 125028] [Curl] There is no way to specify cache folder.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 21 11:19:42 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=125028





--- Comment #5 from Brent Fulgham <bfulgham at webkit.org>  2014-01-21 11:17:12 PST ---
(From update of attachment 221747)
View in context: https://bugs.webkit.org/attachment.cgi?id=221747&action=review

> Tools/WinLauncher/WinLauncher.cpp:394
> +static bool getAppDataFolder(std::wstring& directory)

Why not take a _bstr_t intend? Then you don't have to do all the conversion to/from std::wsting?

> Tools/WinLauncher/WinLauncher.cpp:448
> +    BSTR location = SysAllocString(appDataFolder.data());

If you use a _bstr_t you don't need to SysAlloc and SysFree manually. This is already used in WInLauncher.cpp, so it should build on all of our Windows targets.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list