[Webkit-unassigned] [Bug 125006] [curl] Improve detecting and handling of SSL client certificate
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 21 11:26:20 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=125006
--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> 2014-01-21 11:23:51 PST ---
(From update of attachment 219063)
View in context: https://bugs.webkit.org/attachment.cgi?id=219063&action=review
Looks good, but I had a couple of comments before we land this.
> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:131
> + LOG(Network, "Invalid client certificate file: %s!\n", certificate.latin1().data());
I think this should be certificate.utf8().data().
> Source/WebCore/platform/network/curl/SSLHandle.cpp:60
> + if (it != allowedClientHosts.end()) {
This should probably be an early return for clarity. If it already exists, there's nothing to do.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list