[Webkit-unassigned] [Bug 94488] --disable-dependency-tracking causes build failure due to missing directories

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 7 04:11:56 PST 2014


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
 Attachment #193474|review?                     |review-
               Flag|                            |

--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2014-01-07 04:09:41 PST ---
(From update of attachment 193474)
View in context: https://bugs.webkit.org/attachment.cgi?id=193474&action=review

Thanks for the patch! I think the changes are OK, just a few changelog style issues that need fixing.

> Source/WebCore/ChangeLog:6
> +        Autotools build fix: Ensure output directory existing
> +        before generating DerivedSources. This allows for
> +        --disable-dependency-tracking to be run.
> +        https://bugs.webkit.org/show_bug.cgi?id=94488

This should be the bug's title, not the change description, change description should go bellow the Reviewed by line.

> Source/WebCore/ChangeLog:10
> +        No new tests (OOPS!).

You should remove this line.

> Source/WebCore/ChangeLog:14
> +        * GNUmakefile.am:
> +            Added new target DerivedSources/ANGLE which is a directory to be
> +            created

You should start the change descrtiption detail right after the colon, lines do not need to be split at 80 columns, these could be a single line.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list