[Webkit-unassigned] [Bug 128422] Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128422





--- Comment #17 from Timothy Hatcher <timothy at apple.com>  2014-02-20 09:08:27 PST ---
(From update of attachment 224749)
View in context: https://bugs.webkit.org/attachment.cgi?id=224749&action=review

Looking good to me, but I will let Joe review too.

> Tools/Scripts/webkitpy/style/checkers/js.py:67
> +            if (line.endswith("*/")):

We have had cases where there is a space after the comment ends that this wouldn't catch.

> Tools/Scripts/webkitpy/style/checkers/js.py:71
> +            if (line.startswith("/*") or line.startswith("*")):

Not a foolproof check for multi-line comments, but we don't use them much at all. This will take care of the license comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.