[Webkit-unassigned] [Bug 128422] Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128422


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224749|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #18 from Joseph Pecoraro <joepeck at webkit.org>  2014-02-20 12:10:15 PST ---
(From update of attachment 224749)
View in context: https://bugs.webkit.org/attachment.cgi?id=224749&action=review

r=me! I like this much better! Thanks for looking into it again.

> Tools/Scripts/webkitpy/style/checkers/js.py:75
> +            # Remove strings

Nit: Remove "double quoted" strings.

> Tools/Scripts/webkitpy/style/checkers/js.py:76
> +            line = re.compile(r'"(?:[^"\\]|\\.)*"', re.MULTILINE).sub('""', line)

Nit: I don't think you need re.MULTILINE. The input string (line) is only a single line anyways right?

> Tools/Scripts/webkitpy/style/checkers/js.py:78
> +            # Remove single line comment if any

Nit: Comment should be full sentences that end in a period. That applies to all these # comments.

> Tools/Scripts/webkitpy/style/checkers/js.py:88
> +            line = re.compile('/.+?/', re.MULTILINE).sub('//', line)

Ditto regarding MULTILINE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.