[Webkit-unassigned] [Bug 139757] [EFL] Delegates scrolling by wheel event should be work within contents area.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139757

--- Comment #3 from Sanghyup Lee <sh53.lee at samsung.com> ---
(In reply to comment #2)
> Comment on attachment 243488 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243488&action=review
> 
> A bug fix like this needs a regression test. Could you please write a
> regression test that demonstrates the bug is fixed and add that to this
> patch? Or if that’s not possible, you could document why a regression test
> was impossible or impractical to make in the change log.
> 
> > Source/WebCore/ChangeLog:3
> > +        [EFL] Delegates scrolling by wheel event should be work within contents area.
> 
> This patch should affect any platform that uses delegatesScrolling, not just
> EFL, so it’s not appropriate for the bug title to say [EFL].
> 
> > Source/WebCore/page/FrameView.cpp:4351
> > +            ScrollView::setScrollOffset(IntPoint(newOffset));
> 
> Should call setScrollOffset, not ScrollView::setScrollOffset.

Thank you for your review. I'll fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141219/1cdba582/attachment-0002.html>