[Webkit-unassigned] [Bug 139757] [EFL] Delegates scrolling by wheel event should be work within contents area.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139757

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243488|review?                     |review-
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 243488
  --> https://bugs.webkit.org/attachment.cgi?id=243488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243488&action=review

A bug fix like this needs a regression test. Could you please write a regression test that demonstrates the bug is fixed and add that to this patch? Or if that’s not possible, you could document why a regression test was impossible or impractical to make in the change log.

> Source/WebCore/ChangeLog:3
> +        [EFL] Delegates scrolling by wheel event should be work within contents area.

This patch should affect any platform that uses delegatesScrolling, not just EFL, so it’s not appropriate for the bug title to say [EFL].

> Source/WebCore/page/FrameView.cpp:4351
> +            ScrollView::setScrollOffset(IntPoint(newOffset));

Should call setScrollOffset, not ScrollView::setScrollOffset.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141218/f5729b0f/attachment-0002.html>