[Webkit-unassigned] [Bug 139179] HTMLSelectElement add() should support index as second argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139179

--- Comment #18 from Darin Adler <darin at apple.com> ---
(In reply to comment #17)
>       But other 3 tests ( dom/html/level2/html/HTMLSelectElement18.html,
> dom/xhtml/level2/html/HTMLSelectElement18.xhtml,
> fast/dom/dom-add-optionelement.html) are failing, when 'null' is passed as
> second argument to add(). Whenever select.add(element1,null) is passed, the
> new add api is adding the element1 to begining of the list, so but as per
> spec "If before is omitted, null, or a number out of range, then element
> will be added at the end of the list". so these is making all 3 tests fail. 

Yes, thus it sounds like an incompatible change; probably no big deal, but we need to modify the tests to expect the new behavior, and reaffirm that changing this behavior will be OK for web compatibility and even compatibility in in-app use of WebKit. Never trivial, but as I said, probably fine.

The absolute minimum is to correct our tests and expectations as part of the same check-in that changes the behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141217/5a51a53a/attachment-0002.html>