[Webkit-unassigned] [Bug 139661] Make lookup an immediate action instead of an action menu item

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139661

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243329|review?                     |review+
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 243329
  --> https://bugs.webkit.org/attachment.cgi?id=243329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243329&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:518
> +        // Run the animations serially because attaching another subwindow breaks the bounce animation.
> +        // We could consider making the bounce NSAnimationNonblockingThreaded instead, which seems
> +        // to work, but need to consider all of the implications.

Please remove this comment.

> Source/WebKit/mac/WebView/WebImmediateActionController.mm:350
> +    DictionaryPopupInfo dictionaryPopupInfo = dictionaryPopupInfoForRange(frame, *dictionaryRange, options, TextIndicatorPresentationTransition::BounceAndCrossfade);

Plz just bounce.

> Source/WebKit/mac/WebView/WebView.mm:8662
> +- (id)_animationControllerForDictionaryLookupPopupInfo:(const DictionaryPopupInfo&)dictionaryPopupInfo

It would be nice if someday this could share more code with the function above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141216/4381c162/attachment-0002.html>