[Webkit-unassigned] [Bug 139661] Make lookup an immediate action instead of an action menu item

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 15 16:39:27 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=139661

--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 243329 did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:317:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:998:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:998:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:998:  The parameter name "presentationTransition" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:519:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:519:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 6 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141216/964c683b/attachment-0002.html>


More information about the webkit-unassigned mailing list