[Webkit-unassigned] [Bug 137685] [GTK] Move click counter logic back to WebKitWebViewBase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137685

--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #8)
> Comment on attachment 243124 [details]
> New patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243124&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:768
> > +    // For double and triple clicks GDK sends both a normal button press event
> > +    // and a specific type (like GDK_2BUTTON_PRESS). If we detect a special press
> > +    // coming up, ignore this event as it certainly generated the double or triple
> > +    // click. The consequence of not eating this event is two DOM button press events
> > +    // are generated.
> > +    GUniquePtr<GdkEvent> nextEvent(gdk_event_peek());
> > +    if (nextEvent && (nextEvent->any.type == GDK_2BUTTON_PRESS || nextEvent->any.type == GDK_3BUTTON_PRESS))
> >          return TRUE;
> 
> I think I prefer this method as part of the click counter, since
> understanding types of click events is what it's good at.

it doesn't use anything from the click counter

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141211/a4ad778b/attachment-0002.html>