[Webkit-unassigned] [Bug 139491] [GTK] Add initial database process support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139491

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> Comment on attachment 243042 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243042&action=review
> 
> Looks reasonable to me, though maybe someone with more GVariant experience
> should double-check the type strings.
> 
> > Source/WebKit2/Shared/gtk/KeyedDecoder.cpp:2
> > + * Copyright (C) 2014 Apple Inc. All rights reserved.
> 
> I think we also want an Igalia copyright here too.

Right, I forgot to update that after copy-pasting :-P

> > Source/WebKit2/Shared/gtk/KeyedDecoder.cpp:55
> > +    while (g_variant_iter_loop (&iter, "{&sv}", &key, &value))
> 
> Extra space here after g_variant_iter_loop.

Good catch!

> > Source/WebKit2/Shared/gtk/KeyedEncoder.cpp:2
> > + * Copyright (C) 2013 Apple Inc. All rights reserved.
> 
> I think we want an Igalia copyright here too.

Right

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141210/b010631c/attachment-0002.html>