[Webkit-unassigned] [Bug 139491] [GTK] Add initial database process support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139491

--- Comment #5 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 243042
  --> https://bugs.webkit.org/attachment.cgi?id=243042
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243042&action=review

Looks reasonable to me, though maybe someone with more GVariant experience should double-check the type strings.

> Source/WebKit2/Shared/gtk/KeyedDecoder.cpp:2
> + * Copyright (C) 2014 Apple Inc. All rights reserved.

I think we also want an Igalia copyright here too.

> Source/WebKit2/Shared/gtk/KeyedDecoder.cpp:55
> +    while (g_variant_iter_loop (&iter, "{&sv}", &key, &value))

Extra space here after g_variant_iter_loop.

> Source/WebKit2/Shared/gtk/KeyedEncoder.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

I think we want an Igalia copyright here too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141210/b5660e94/attachment-0002.html>