[Webkit-unassigned] [Bug 78883] [GStreamer] AudioSourceProvider support in the MediaPlayer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78883

--- Comment #53 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 242916
  --> https://bugs.webkit.org/attachment.cgi?id=242916
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242916&action=review

> Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:79
> +    if (gst_adapter_available(adapter) >= bytes) {

This could lead to accumulating more and more data until OOM if data is pulled slower from here than GStreamer produces. Maybe should just call gst_app_sink_pull_sample() from here to have appsink block in that case? That could still cause problems if appsink produces more than $bytes large buffers, so in the case when there is still data in the adapter you wouldn't pull.

Don't forget to set max-buffers on appsink to something then :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141210/917310b7/attachment-0002.html>