[Webkit-unassigned] [Bug 78883] [GStreamer] AudioSourceProvider support in the MediaPlayer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78883

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242916|review?                     |review+
              Flags|                            |

--- Comment #52 from Gustavo Noronha (kov) <gns at gnome.org> ---
Comment on attachment 242916
  --> https://bugs.webkit.org/attachment.cgi?id=242916
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242916&action=review

A few nits in addition to the ones we discussed in person =)

> Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:35
> +// For now the provider supports only stereo files at a fixed sample
> +// bitrate.

Nit: no need to split this line.

> Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:283
> +    callbacks.eos = 0;
> +    callbacks.new_preroll = 0;

nullptr

> Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:285
> +    gst_app_sink_set_callbacks(GST_APP_SINK(sink), &callbacks, this, 0);

nullptr

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141209/187a1a5b/attachment-0002.html>