[Webkit-unassigned] [Bug 136325] Pass the resource identifier in willSendRequest callback.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 29 10:03:21 PDT 2014


--- Comment #4 from Darin Adler <darin at apple.com>  2014-08-29 10:03:27 PST ---
(From update of attachment 237275)
View in context: https://bugs.webkit.org/attachment.cgi?id=237275&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:54
> +- (NSURLRequest *)webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController *)controller frame:(WKWebProcessPlugInFrame *)frame willSendRequestForResource:(uint64_t)resource request:(NSURLRequest *)request redirectResponse:(NSURLResponse *)redirectResponse;

How can we just change a protocol like this in public API? Don’t we need to keep existing clients compatible? I think there’s a pattern we need to follow here to deprecate an old method signature and replace it with a new one, calling the old one if the new one isn’t present.

Or maybe this isn’t public API yet?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list