[Webkit-unassigned] [Bug 136325] Pass the resource identifier in willSendRequest callback.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136325





--- Comment #5 from Yongjun Zhang <yongjun_zhang at apple.com>  2014-08-29 10:55:48 PST ---
(In reply to comment #4)
> (From update of attachment 237275 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237275&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:54
> > +- (NSURLRequest *)webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController *)controller frame:(WKWebProcessPlugInFrame *)frame willSendRequestForResource:(uint64_t)resource request:(NSURLRequest *)request redirectResponse:(NSURLResponse *)redirectResponse;
> 
> How can we just change a protocol like this in public API? Don’t we need to keep existing clients compatible? I think there’s a pattern we need to follow here to deprecate an old method signature and replace it with a new one, calling the old one if the new one isn’t present.
> 
> Or maybe this isn’t public API yet?

No, this is not public API yet and it is subject to change.  That said, I think it is better to follow the staging pattern that falls back to old signature if the new method isn't implemented by the delegate.  And we can remove the check when all client are moving to the new method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.