[Webkit-unassigned] [Bug 136048] Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136048





--- Comment #3 from Peyton Randolph <prandolph at apple.com>  2014-08-18 14:21:01 PST ---
(In reply to comment #2)
> (From update of attachment 236782 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171
> > +    WKBundlePageDidBeginTrackingPotentialLongMousePressCallback            didBeginTrackingPotentialLongMousePress;
> > +    WKBundlePageDidRecognizeLongMousePressCallback                         didRecognizeLongMousePress;
> > +    WKBundlePageDidCancelTrackingPotentialLongMousePressCallback           didCancelTrackingPotentialLongMousePress;
> 
> These last three aren’t aligned with all of the above.

Aligned.
> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209
> > +    WKTypeRef userDataToPass = 0;
> 
> Please use nullptr.

Fixed.

> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219
> > +    WKTypeRef userDataToPass = 0;
> 
> Ditto.

Fixed.
> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229
> > +    WKTypeRef userDataToPass = 0;
> 
> Ditto.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.