[Webkit-unassigned] [Bug 136048] Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 18 14:09:45 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=136048


mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236782|review?                     |review+
               Flag|                            |




--- Comment #2 from mitz at webkit.org <mitz at webkit.org>  2014-08-18 14:09:53 PST ---
(From update of attachment 236782)
View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171
> +    WKBundlePageDidBeginTrackingPotentialLongMousePressCallback            didBeginTrackingPotentialLongMousePress;
> +    WKBundlePageDidRecognizeLongMousePressCallback                         didRecognizeLongMousePress;
> +    WKBundlePageDidCancelTrackingPotentialLongMousePressCallback           didCancelTrackingPotentialLongMousePress;

These last three aren’t aligned with all of the above.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209
> +    WKTypeRef userDataToPass = 0;

Please use nullptr.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219
> +    WKTypeRef userDataToPass = 0;

Ditto.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229
> +    WKTypeRef userDataToPass = 0;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list