[Webkit-unassigned] [Bug 135795] [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135795





--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-08-16 00:08:12 PST ---
(From update of attachment 236363)
View in context: https://bugs.webkit.org/attachment.cgi?id=236363&action=review

> Tools/MiniBrowser/efl/main.c:1138
> +on_navigation_button_longpress(void *user_data)

This is not callback function which is registered by evas_object_event_callback_add. So, how do you think just to use navigaton_button_longpress_process() ?

> Tools/MiniBrowser/efl/main.c:1149
> +        int item_count, x = 0, y = 0, width = 0, height = 0;

Looks C coding style. MiniBrowser is compiled by C++ compiler.

> Tools/MiniBrowser/efl/main.c:1163
> +        for (index = 0; index < item_count; index++) {

index -> int index ?

> Tools/MiniBrowser/efl/main.c:2154
> +    Eina_Bool auto_repeat = elm_button_autorepeat_get(window->back_button);

Could you explain why we need to check if the autorepeat is enabled ? It looks back_button's auto repeat setting is always enabled or disabled.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.