[Webkit-unassigned] [Bug 135795] [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 13 04:03:56 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=135795





--- Comment #3 from Tanay <tanay.c at samsung.com>  2014-08-13 04:04:03 PST ---
(In reply to comment #2)
> (From update of attachment 236363 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236363&action=review
> 
> > Tools/MiniBrowser/efl/main.c:62
> > +static Eina_Bool forward_navigation_enabled = EINA_FALSE;
> 
> Patch looks good. However, these two boolean flags may disturb upcoming patch for MiniBrowser. Can't we call callbacks when long press is detected directly ?

The flags are required due to following reasons:
1) evas button registers both 'clicked' + 'repeated' event when the button is released after longpress. This results in callback for 'clicked' which should be avoided. longpress_enabled is required to differentiate between 'repeated' and 'clicked' events.

2)Also multiple longpress callbacks are recieved when the user longpress the button. We require to process only once and ignore the rest of the calls.

3) forward_navigation flag is required to differentiate the navigation direction. Without this we would not be able to know the direction of navigation.

If there are alternatives to avoid the flags please do suggest. Due to above limitations I am using this approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list