[Webkit-unassigned] [Bug 135768] Implement scroll snapping animations on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135768





--- Comment #12 from Wenson Hsieh <wenson_hsieh at apple.com>  2014-08-14 09:21:21 PST ---
(From update of attachment 236573)
View in context: https://bugs.webkit.org/attachment.cgi?id=236573&action=review

>> Source/WebCore/PlatformMac.cmake:134
>> +    platform/mac/AxisScrollSnapAnimator.mm
> 
> I think this file is sorted.

Fixed.

>> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:171
>> +    LayoutUnit lowerSnapPosition = snapOffsets.at(lowerIndex);
> 
> We have operator[]; why .at()?

Thanks for the tip -- changed to use [].

>> Source/WebCore/platform/mac/AxisScrollSnapAnimator.h:90
>> +    ScrollSnapState m_curState;
> 
> "cur" :( Spell it out!

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.