[Webkit-unassigned] [Bug 135768] Implement scroll snapping animations on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135768





--- Comment #11 from Tim Horton <thorton at apple.com>  2014-08-13 21:50:56 PST ---
(From update of attachment 236573)
View in context: https://bugs.webkit.org/attachment.cgi?id=236573&action=review

I gave up when I hit the math.

> Source/WebCore/ChangeLog:14
> +        final velocity matches a lower final velocity that is somewhat arbitrarily computed. (See the FIXME in

Isn't the "final" velocity 0 by definition? Maybe this will make sense later.

> Source/WebCore/PlatformMac.cmake:134
> +    platform/mac/AxisScrollSnapAnimator.mm

I think this file is sorted.

> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:171
> +    LayoutUnit lowerSnapPosition = snapOffsets.at(lowerIndex);

We have operator[]; why .at()?

> Source/WebCore/platform/mac/AxisScrollSnapAnimator.h:90
> +    ScrollSnapState m_curState;

"cur" :( Spell it out!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.