[Webkit-unassigned] [Bug 135476] Implement long mouse press over links. Part of 135257 - Add long mouse press gesture.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135476





--- Comment #5 from Peyton Randolph <prandolph at apple.com>  2014-08-01 16:17:32 PST ---
(In reply to comment #4)
> (From update of attachment 235855 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235855&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:167
> > +const double longMousePressDelay = 0.5;
> 
> This could use std::chrono so the units are explicit.

Done.

> 
> > Source/WebCore/page/EventHandler.cpp:168
> > +const int longMousePressHysteresis = 5;
> 
> What is this value? Pixels? The name should make it clear.

Renamed to longMousePressPointsHysteresis.

> 
> > Source/WebCore/page/EventHandler.cpp:1583
> > +    // FIXME: bubble long mouse press up to UI process.
> 
> This comment doesn't make sense here, since EventHandler is also used in non-mulitprocess mode.

Reworded to FIXME: bubble long mouse press up to the client.

> 
> > Source/WebCore/page/EventHandler.cpp:1588
> > +    // FIXME: bubble long mouse press up to UI process.
> 
> Ditto, etc.

Done.
> 
> > Source/WebCore/page/EventHandler.cpp:1627
> > +        if (FrameView* view = m_frame.view())
> > +            view->setCursor(pointerCursor());
> 
> It seems a bit odd to reset the cursor here. Why?

Removed. The thinking was to reset the cursor because if the user moves their mouse a significant distance after recognizing the long press, it looks odd if the cursor is still a pointer, i-bar, or a wacky custom cursor. I added this because HandleDrag does the same. But it's not really necessary.

> 
> > Source/WebCore/page/EventHandler.h:384
> > +    bool mouseHysteresisExceeded(const FloatPoint&, const int) const;
> 
> The second parameter should be named here.

Named pointsThreshold.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.