[Webkit-unassigned] [Bug 132024] [iOS] WebKit2 File Upload Support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132024





--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org>  2014-04-30 13:52:10 PST ---
(From update of attachment 230403)
View in context: https://bugs.webkit.org/attachment.cgi?id=230403&action=review

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:695
> +        title = [NSString stringWithFormat:WEB_UI_STRING_KEY("%@ Photos and %@ Videos", "# Photos and # Videos (file upload on page label for image and videos)", "File Upload images and videos label"), imageCountString, videoCountString];
> +        break;

Arg this won't work for 1 photo and 1 video this would say "1 Photos and 1 Videos". I think I misinterpreted Darin's comment. It sounds like, if I want to make explicit strings to handle the "and" case I would need a bunch just for that:

    "1 Photo and 1 Video"
    "1 Photo and # Videos"
    "# Photos and 1 Video"
    "# Photos and # Videos"

A bit lengthy, but I can do that. I'll do it in a follow-up. And then I can clean up this code since we wouldn't really need the earlier switches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.