[Webkit-unassigned] [Bug 132024] [iOS] WebKit2 File Upload Support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132024


Enrica Casucci <enrica at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230403|review?                     |review+
               Flag|                            |




--- Comment #9 from Enrica Casucci <enrica at apple.com>  2014-04-29 16:40:23 PST ---
(From update of attachment 230403)
View in context: https://bugs.webkit.org/attachment.cgi?id=230403&action=review

The patch looks good. One remaining question: don't you need to handle rotation? I know we do it for select elements and for the airplay picker.

>>> Source/WebKit2/ChangeLog:9
>>> +        Include MobileCoreServices on iOS for kUTTypeImage/kUTTypeMovie.
>> 
>> Couldn't you soft link MobileCoreServices? We already do that in WebCore and I think it would be more performant.
> 
> I figure there is no advantage to soft linking it if UIKit is hard linking it and this hard links UIKit, but maybe my understanding of this is flawed.

You are right, I forgot we link UIKit.

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:653
> +    NSString *imageCountString, *videoCountString;

Split over two lines.

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:654
> +    NSString *imageString, *videoString;

Ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.