[Webkit-unassigned] [Bug 132228] [GTK] TextTrack kind and mode attributes are enums since r166180

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132228





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-04-28 00:11:27 PST ---
(In reply to comment #2)
> (From update of attachment 230257 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230257&action=review
> 
> Looks good with a few minor suggestions.

Thanks

> > Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:74
> > +    gchar* result = convertToUTF8String(item->kind());
> > +    return result;
> 
> Can you just return convertToUTF8String(item->kind()); ?

Sure, this is actually generated code, but added manually. I think this happens in the generated code because if the method raises exceptions there's code to deal with them, between the two lines. 

> > Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:103
> > +    WebCore::TextTrack* item = WebKit::core(self);
> > +    WTF::String convertedValue = WTF::String::fromUTF8(value);
> > +    item->setMode(convertedValue);
> 
> Can't this just be WebKit::core(self)->setMode(WTF::String::fromUTF8(value)); ?

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.