[Webkit-unassigned] [Bug 132228] [GTK] TextTrack kind and mode attributes are enums since r166180

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132228


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230257|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2014-04-27 04:07:43 PST ---
(From update of attachment 230257)
View in context: https://bugs.webkit.org/attachment.cgi?id=230257&action=review

Looks good with a few minor suggestions.

> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:74
> +    gchar* result = convertToUTF8String(item->kind());
> +    return result;

Can you just return convertToUTF8String(item->kind()); ?

> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:103
> +    WebCore::TextTrack* item = WebKit::core(self);
> +    WTF::String convertedValue = WTF::String::fromUTF8(value);
> +    item->setMode(convertedValue);

Can't this just be WebKit::core(self)->setMode(WTF::String::fromUTF8(value)); ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.