[Webkit-unassigned] [Bug 131637] Remove back/current/forwardItem() from BackForwardClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131637





--- Comment #3 from Darin Adler <darin at apple.com>  2014-04-19 13:57:13 PST ---
BackForwardClient abstracts what BackForwardList does for WebKit1, but is instead proxied for WebKit2. Any WebKit1-only functions can simply be on BackForwardList and need not be in BackForwardClient.

Besides backItem, currentItem, and forwardItem, that also includes the current, setCurrent, and clearAllPageCaches functions. All six of them should be removed, and made non-virtual in BackForwardList.

Another thing that’s wrong with BackForwardClient is that it should not be reference counted. It has no shared ownership need that I can see. So BackForwardController::m_client should be a unique_ptr rather than a RefPtr. And the BackForwardController::client function should return a reference, not a pointer. And we should consider getting rid of it completely; it’s only there so WebKit1 code can recover the BackForwardList pointer, and there must be some better way to do that without a typecast involved.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.