[Webkit-unassigned] [Bug 131637] Remove back/current/forwardItem() from BackForwardClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131637





--- Comment #4 from Brian Burg <burg at cs.washington.edu>  2014-04-22 15:09:33 PST ---
(In reply to comment #3)
> Another thing that’s wrong with BackForwardClient is that it should not be reference counted. It has no shared ownership need that I can see. So BackForwardController::m_client should be a unique_ptr rather than a RefPtr. And the BackForwardController::client function should return a reference, not a pointer. And we should consider getting rid of it completely; it’s only there so WebKit1 code can recover the BackForwardList pointer, and there must be some better way to do that without a typecast involved.


If BackForwardClient is owned, who owns it? In Cocoa WK2, it's passed in from WebPage. If none is provided, the controller makes its own.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.