[Webkit-unassigned] [Bug 131727] Fix the commit-log-editor after r167243 and add more unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 16 03:25:40 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=131727


Csaba Osztrogonác <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossy at webkit.org




--- Comment #1 from Csaba Osztrogonác <ossy at webkit.org>  2014-04-16 03:25:59 PST ---
I think I got the problem. Check this small changelog entry:
------------------------------------------------------------------------------
2014-04-14  Peter Molnar  <pmolnar.u-szeged at partner.samsung.com>

        Fix incorrect indentations in CodeGeneratorJS.pm introduced in r165521
        https://bugs.webkit.org/show_bug.cgi?id=131613

        Reviewed by Csaba Osztrogonác.

        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateImplementation):
        Fixed 5-space indentation.
        * bindings/scripts/test/JS/JSTestNondeterministic.cpp:
        Updated the tests accordingly.

------------------------------------------------------------------------------



In this case the common prefix was:
------------------------------------------------------------------------------
2014-04-14  Peter Molnar  <pmolnar.u-szeged at partner.samsung.com>


        Fix incorrect indentations in CodeGeneratorJS.pm introduced in r165521
        https://bugs.webkit.org/show_bug.cgi?id=131613

        Reviewed by Csaba Osztrogonác.

------------------------------------------------------------------------------



And the non-common part was:
------------------------------------------------------------------------------


        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateImplementation):
        Fixed 5-space indentation.
        * bindings/scripts/test/JS/JSTestNondeterministic.cpp:
        Updated the tests accordingly.

------------------------------------------------------------------------------

The problem was that commit-log-editor relied on the extra \n\n in non-common
parts and it didn't add any \n after the name of the label, eg: "WebCore:"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list