[Webkit-unassigned] [Bug 131727] New: Fix the commit-log-editor after r167243 and add more unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 16 03:11:48 PDT 2014


           Summary: Fix the commit-log-editor after r167243 and add more
                    unit tests
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
                CC: ap at webkit.org, jberta.u-szeged at partner.samsung.com

http://trac.webkit.org/changeset/167243 broke a webkitpy 
unit test and update landed in http://trac.webkit.org/r167296

Sorry for causing troubles, I didn't know if there is a webkitpy
unit test for the Tools/Scripts/commit-log-editor perl script.
I checked the webkitperl directory and haven't seen any unit
test for this script, that's why I didn't want to expect the
author to implement a unit test from the scratch for a script
which can't be mockable and relies on filesystem changes.

But know we know that we have an existing unit test for 
it in webkitpy, so we should add unit tests for r167243.

Additionally I think the new behaviour which caused the
unit test failure isn't the expected result, we didn't
want to remove the extra newline after directory names.
I think it is a minor bug which can be fixed easily.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list