[Webkit-unassigned] [Bug 131521] Pipe initial scale factor to TileController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131521





--- Comment #7 from Antti Koivisto <koivisto at iki.fi>  2014-04-11 11:46:32 PST ---
(In reply to comment #6)
> (From update of attachment 229143 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229143&action=review
> 
> > Source/WebCore/platform/graphics/GraphicsLayerClient.h:89
> > +    virtual float zoomedOutPageScaleFactor() const { return 0; }
> 
> Would getting a zero cause trouble anywhere? (divide-by-zero, etc.)

The plan is to use it to mean "disabled". Might change it later.

> Every 'push' property we've had on TileController has caused trouble (and we have since made many 'pull' via PlatformCALayerClient), but I think this one is OK because it's called from updateContentsScale. That said, I would not be opposed to inverting it.

Yeah, push is right thing to do for things that go via layer commits

> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:75
> > +typedef int AVPlayerViewControllerExitFullScreenReason;
> 
> ?

Oops, build fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.