[Webkit-unassigned] [Bug 131521] Pipe initial scale factor to TileController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131521


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #229143|review?                     |review+
               Flag|                            |




--- Comment #6 from Tim Horton <thorton at apple.com>  2014-04-11 11:42:45 PST ---
(From update of attachment 229143)
View in context: https://bugs.webkit.org/attachment.cgi?id=229143&action=review

> Source/WebCore/platform/graphics/GraphicsLayerClient.h:89
> +    virtual float zoomedOutPageScaleFactor() const { return 0; }

Would getting a zero cause trouble anywhere? (divide-by-zero, etc.)

> Source/WebCore/platform/graphics/TiledBacking.h:92
> +    virtual void setZoomedOutContentsScale(float) = 0;
> +    virtual float zoomedOutContentsScale() const = 0;

Every 'push' property we've had on TileController has caused trouble (and we have since made many 'pull' via PlatformCALayerClient), but I think this one is OK because it's called from updateContentsScale. That said, I would not be opposed to inverting it.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:75
> +typedef int AVPlayerViewControllerExitFullScreenReason;

?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.