[Webkit-unassigned] [Bug 131483] [EFL][WK2] Implement web notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131483





--- Comment #2 from Jinwoo Song <jinwoo7.song at samsung.com>  2014-04-10 21:57:16 PST ---
(From update of attachment 229033)
View in context: https://bugs.webkit.org/attachment.cgi?id=229033&action=review

API unit test should be added.(maybe in other bug.)

> Source/WebKit2/UIProcess/API/efl/ewk_notification.cpp:55
> +    m_ewkView = 0;

s/0/nullptr

> Source/WebKit2/UIProcess/API/efl/ewk_notification_permission_request_private.h:51
> +    explicit EwkNotificationPermissionRequest(WKNotificationPermissionRequestRef, WKSecurityOriginRef);

We do not need *explicit* keyword here.

> Source/WebKit2/UIProcess/API/efl/ewk_notification_private.h:64
> +    explicit EwkNotification(WKNotificationRef, EwkView*);

We do not need *explicit* keyword here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.