[Webkit-unassigned] [Bug 131483] [EFL][WK2] Implement web notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131483





--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2014-04-10 22:42:02 PST ---
(From update of attachment 229033)
View in context: https://bugs.webkit.org/attachment.cgi?id=229033&action=review

Good. I commented bit.

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:83
> +#if ENABLE(NOTIFICATIONS)
> +    , m_notificationProvider(std::make_unique<NotificationProvider>(context))
> +#endif

How about creating it as lazy as possible?

And, should we add it in not ewk_view but ewk_context ?

> Source/WebKit2/UIProcess/API/efl/ewk_notification.cpp:51
> +{ }

We use different line for }

> Source/WebKit2/UIProcess/efl/NotificationProvider.h:39
> +class NotificationProvider {

NotificationProviderEfl?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.