[Webkit-unassigned] [Bug 131050] Web Inspector: Provide a way for JSContext console to log to system console

Tue Apr 1 12:14:29 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=131050

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228304|review?                     |review+
               Flag|                            |

--- Comment #4 from Timothy Hatcher <timothy at apple.com>  2014-04-01 12:14:48 PST ---
(From update of attachment 228304)
View in context: https://bugs.webkit.org/attachment.cgi?id=228304&action=review

> Source/JavaScriptCore/inspector/JSConsoleClient.cpp:62
> +    Boolean preference = CFPreferencesGetAppBooleanValue(CFSTR("JavaScriptCoreConsoleLogToSystemConsole"), kCFPreferencesCurrentApplication, &keyExistsAndHasValidFormat);

JavaScriptCoreConsoleLogToSystemConsole implies only console.log is printed. A verb like "output" would help too. Maybe: OutputJavaScriptCoreConsoleToSystemConsole. Does this work for WebKit too? Maybe OutputJavaScriptConsoleToSystemConsole if so.

> Source/JavaScriptCore/inspector/JSConsoleClient.cpp:82
> +    if (JSConsoleClient::logToSystemConsole())

No need for JSConsoleClient:: right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.